Added distance-based localization functions to class Field#12455
Merged
oddvarlia merged 1 commit intoequinor:mainfrom Dec 15, 2025
Merged
Conversation
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
from
b209c00 to
1a2b7a0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12455 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.02%
==========================================
Files 434 434
Lines 29569 29577 +8
==========================================
+ Hits 26816 26818 +2
- Misses 2753 2759 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12455 will not alter performanceComparing Summary
|
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
2 times, most recently
from
a74c2f5 to
acf9901
Compare
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
2 times, most recently
from
3751f24 to
63a2e4c
Compare
xjules
reviewed
Dec 8, 2025
xjules
reviewed
Dec 8, 2025
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
3 times, most recently
from
a95894b to
42094e0
Compare
Contributor
|
Very nice @oddvarlia ! I think the commit message can be updated to account for the removal of those two functions. |
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
2 times, most recently
from
a0adeba to
ed034fe
Compare
Collaborator
Author
|
Updated commit message so it is consistent with the changes. Removed reference to functions not anymore included in class Field |
xjules
reviewed
Dec 11, 2025
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
2 times, most recently
from
89e59c6 to
dc35985
Compare
Added snapshot test for update of Field class Functions: - calc_rho_for_2d_grid_layer to calculate elements for the RHO matrix using the localization influence area (elliptic areas around observation positions)
oddvarlia
force-pushed
the
distance_localization_update_of_3d_fields
branch
from
dc35985 to
7b6b732
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions in class Field to be used when calculating the RHO matrix for distance-based localization.
This is related to #12452 since it requires the update of the field_utils.py