Skip to content

Revert "Deprecate DESIGN_KW"#12451

Merged
jonathan-eq merged 1 commit intoequinor:version-17.0from
jonathan-eq:version-17.0
Dec 4, 2025
Merged

Revert "Deprecate DESIGN_KW"#12451
jonathan-eq merged 1 commit intoequinor:version-17.0from
jonathan-eq:version-17.0

Conversation

@jonathan-eq
Copy link
Copy Markdown
Contributor

@jonathan-eq jonathan-eq commented Dec 4, 2025

This reverts commit f67ebd5.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq added the release-notes:skip If there should be no mention of this in release notes label Dec 4, 2025
@jonathan-eq jonathan-eq added this to SCOUT Dec 4, 2025
@jonathan-eq jonathan-eq moved this to Ready for Review in SCOUT Dec 4, 2025
@jonathan-eq jonathan-eq self-assigned this Dec 4, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.54%. Comparing base (f7d463b) to head (7aeb41c).

Additional details and impacted files
@@              Coverage Diff              @@
##           version-17.0   #12451   +/-   ##
=============================================
  Coverage         90.54%   90.54%           
=============================================
  Files               434      434           
  Lines             29067    29067           
=============================================
  Hits              26319    26319           
  Misses             2748     2748           
Flag Coverage Δ
cli-tests 37.61% <ø> (ø)
gui-tests 68.99% <ø> (ø)
performance-and-unit-tests 73.96% <ø> (ø)
test 38.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #12451 will not alter performance

Comparing jonathan-eq:version-17.0 (7aeb41c) with main (43455c6)1

Summary

✅ 22 untouched

Footnotes

  1. No successful run was found on version-17.0 (f7d463b) during the generation of this report, so main (43455c6) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-project-automation github-project-automation Bot moved this from Ready for Review to Reviewed in SCOUT Dec 4, 2025
@jonathan-eq jonathan-eq merged commit d566318 into equinor:version-17.0 Dec 4, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Dec 4, 2025
@jonathan-eq jonathan-eq removed the release-notes:skip If there should be no mention of this in release notes label Dec 4, 2025
@jonathan-eq jonathan-eq deleted the version-17.0 branch February 25, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants