refactor: introduce upstream choke pressure control strategy#1427
Merged
refactor: introduce upstream choke pressure control strategy#1427
Conversation
tj098895
reviewed
Mar 12, 2026
src/libecalc/domain/process/process_solver/pressure_control/upstream_choke.py
Show resolved
Hide resolved
6420b79 to
0b1bfd9
Compare
fb823b2 to
388a137
Compare
jsolaas
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpstreamChokePressureControlStrategy(with runner) as an additional pressure control option.ASVSolverto allow upstream choke pressure control to be applied after speed selection.UpstreamChokeSolverrobust by adding an endpoint feasibility/bracketing check to avoid root-finding exceptions when the target is not achievable within the upstream ΔP boundary.Refs:
https://github.com/equinor/ecalc-internal/issues/1595
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
What else did you consider?
Between the lines?