Skip to content

refactor: introduce upstream choke pressure control strategy#1427

Merged
frodehk merged 2 commits intomainfrom
refactor/introduce-upstream-pressure-control-strategy
Mar 13, 2026
Merged

refactor: introduce upstream choke pressure control strategy#1427
frodehk merged 2 commits intomainfrom
refactor/introduce-upstream-pressure-control-strategy

Conversation

@frodehk
Copy link
Contributor

@frodehk frodehk commented Mar 12, 2026

Summary

  • Introduce an UpstreamChokePressureControlStrategy (with runner) as an additional pressure control option.
  • Update ASVSolver to allow upstream choke pressure control to be applied after speed selection.
  • Make UpstreamChokeSolver robust by adding an endpoint feasibility/bracketing check to avoid root-finding exceptions when the target is not achievable within the upstream ΔP boundary.
  • Add unit + integration tests.

Refs:
https://github.com/equinor/ecalc-internal/issues/1595


Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?

@frodehk frodehk self-assigned this Mar 12, 2026
@frodehk frodehk requested a review from a team as a code owner March 12, 2026 14:09
@frodehk frodehk force-pushed the refactor/introduce-upstream-pressure-control-strategy branch from 6420b79 to 0b1bfd9 Compare March 13, 2026 07:30
@frodehk frodehk force-pushed the refactor/introduce-upstream-pressure-control-strategy branch from fb823b2 to 388a137 Compare March 13, 2026 09:55
@frodehk frodehk merged commit 898ad6c into main Mar 13, 2026
22 checks passed
@frodehk frodehk deleted the refactor/introduce-upstream-pressure-control-strategy branch March 13, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants