Decodecorpus #5
Merged
Decodecorpus #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyan4973
approved these changes
Jun 27, 2019
|
Looks good to me , Btw, any reason why you preferred to open a new PR (rather than merge the previous one) ? |
Owner
Author
|
@Cyan4973 Oh, for some reason, I thought I need to push to my dev and then make a pull request to facebook/zstd dev from my dev branch. |
|
Indeed, as you have already guessed, it's possible to merge directly from your feature branch into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
./decodecorpus -ptestfiles -otestfiles -n1 -s1236947365 -vto generate an input that has an issue before the fix.