fix:doris_conn cannot get table comment to store vectordb#2490
Merged
Conversation
Contributor
Author
|
@fangyinc Hellothanks for your watching.I have reformatted the file and open a new request.Could you please check if this is correct.Thanks again!😘 |
Aries-ckt
approved these changes
Mar 20, 2025
Collaborator
Aries-ckt
left a comment
Aries-ckt
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
FOkvj
pushed a commit
to FOkvj/DB-GPT
that referenced
this pull request
Mar 23, 2025
…-ai#2490) Co-authored-by: Zhihe.Liu <zhihe.liu@majorbio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Description
When working with Doris as a data source for visualization, I discovered that the vector data queried lacked the corresponding table comments. This absence of table comments was causing a decrease in matching accuracy. To address this issue, I implemented a solution by rewriting the get_table_comment method in the conn_doris module. This enhancement ensures proper retrieval and association of table comments with the vector data, ultimately improving the overall accuracy of data matching and visualization results.