Skip to content

EDPUB-1635: Update react-device-detect usage in dashboard#273

Merged
camposeddie merged 1 commit intodevelopfrom
EDPUB-1635
Jan 29, 2026
Merged

EDPUB-1635: Update react-device-detect usage in dashboard#273
camposeddie merged 1 commit intodevelopfrom
EDPUB-1635

Conversation

@acharya-deepak
Copy link
Copy Markdown
Contributor

Description

react-device-detect library hasn't been updated in a few years. Instead investigate another implementation / package for detecting if a user is using Safari or not for the dashboard.

Linked JIRA Task or Github Issue

JIRA Task: EDPUB-1635
Github Issue: example

Types of changes

What types of changes does your code introduce to Earthdata Pub (EDPub)?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if adding or updating the existing documentation resources)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide
  • I have updated the CHANGELOG
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Validation Steps

This will help us get a jump start on validating your PR by describing the steps to replicate
and validate the expected behavior. (For an example of good validation instructions, check out Bryan's Bouncy Ball PR.)

  1. Make sure all merge request checks have passed (CI/CD).
  2. Pull related branches locally.
  3. Navigate to safari browser and check if the unsupported page is displayed.

@acharya-deepak acharya-deepak requested a review from a team as a code owner January 26, 2026 15:05
Copy link
Copy Markdown
Contributor

@camposeddie camposeddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test until UAT due to needing online Safari emulation and VPN restrictions, but code looks good.

@camposeddie camposeddie merged commit df7e911 into develop Jan 29, 2026
1 check passed
@camposeddie camposeddie deleted the EDPUB-1635 branch January 29, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants