Fix Forms component sidebar implementation#261
Merged
camposeddie merged 1 commit intodevelopfrom Jan 15, 2026
Merged
Conversation
camposeddie
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a misspelling in a path used to determine whether or not the sidebar was displayed. While testing the correction of this misspelling, I identified several undesired behaviors of this implementation. This PR updates the implementation to remove the undesired behaviors which also eliminates the misspelling.
Linked JIRA Task or Github Issue
JIRA Task: EDPUB-1732
Types of changes
What types of changes does your code introduce to Earthdata Pub (EDPub)?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Validation Steps
This will help us get a jump start on validating your PR by describing the steps to replicate
and validate the expected behavior. (For an example of good validation instructions, check out Bryan's Bouncy Ball PR.)
Add FormbuttonBack to FormsFurther comments
I initially just corrected the misspelling, but that made the /forms/add page shift to the left in an unpleasant manner. I found that this was due to the className for the content div being altered by the sidebar value. I couldn't find a reason for the className value to be altered by the sidebar and similar components (Sections, Workflows, Questions) have it hardcoded, so I removed the condition. I also realized that those components don't use conditionals for displaying the sidebar either so I attempted to remove that condition as well. This worked for the most part, but resulted in a quirk where if you navigated to a form review page and then clicked the Back to Forms link in the sidebar, the sidebar box would stay present on the forms, forms/add, forms/edit pages until you did a refresh. This led me to updating the conditional to check for the one case we do want the sidebar displayed.