Prod 24.2.3

CHANGELOG.md

@@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## Unreleased
 
 <!-- Unreleased changes can be added here. -->
+- Updated metadata mapper for DAAC specific questions
+- Updated email notification text formatting to accommodate special characters
 - Updated contact information label to full name from first and last name
 - Renames improperly named /api/data/submission/{operation} endpoints back to the intended /api/submission/{operation}.
 - Add DAAC onboard/offboard endpoints

src/nodejs/lambda-handlers/submission.js

@@ -148,28 +148,31 @@ async function submitMethod(event, user) {
 }
 
 async function reviewMethod(event, user) {
+  const approvedUserPrivileges = ['ADMIN', 'REQUEST_REVIEW', 'REQUEST_REVIEW_MANAGER'];
   const { id, approve } = event;
   const status = await db.submission.getState({ id });
-  const stepType = status.step.type;
-  let eventType;
-  if (approve === 'false' || !approve) {
-    eventType = 'review_rejected';
-  } else if (stepType === 'review') {
-    eventType = 'review_approved';
-  } else {
-    eventType = 'workflow_promote_step';
+  if (user.user_privileges.some((privilege) => approvedUserPrivileges.includes(privilege))) {
+    const stepType = status.step.type;
+    let eventType;
+    if (approve === 'false' || !approve) {
+      eventType = 'review_rejected';
+    } else if (stepType === 'review') {
+      eventType = 'review_approved';
+    } else {
+      eventType = 'workflow_promote_step';
+    }
+    const eventMessage = {
+      event_type: eventType,
+      submission_id: id,
+      conversation_id: status.conversation_id,
+      workflow_id: status.workflow_id,
+      user_id: user.id,
+      data: status.step.data,
+      step_name: status.step_name
+    };
+    if (status.step.step_message) eventMessage.step_message = status.step.step_message;
+    await msg.sendEvent(eventMessage);
   }
-  const eventMessage = {
-    event_type: eventType,
-    submission_id: id,
-    conversation_id: status.conversation_id,
-    workflow_id: status.workflow_id,
-    user_id: user.id,
-    data: status.step.data,
-    step_name: status.step_name
-  };
-  if (status.step.step_message) eventMessage.step_message = status.step.step_message;
-  await msg.sendEvent(eventMessage);
   return status;
 }