Skip to content

Fixing query parameters for non-admin group management#346

Open
ckd002 wants to merge 1 commit intodevelopfrom
hotfix/group-management
Open

Fixing query parameters for non-admin group management#346
ckd002 wants to merge 1 commit intodevelopfrom
hotfix/group-management

Conversation

@ckd002
Copy link
Contributor

@ckd002 ckd002 commented Mar 24, 2026

Description

While writing integration tests I discovered that non-admin roles with the USER_ADDGROUP and USER_REMOVEGROUP privileges were not able to properly add or remove groups because of an internal check. This PR corrects that issue.

Linked JIRA Task or Github Issue

JIRA Task: NA

Types of changes

What types of changes does your code introduce to Earthdata Pub (EDPub)?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if adding or updating the existing documentation resources)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide
  • I have updated the CHANGELOG
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Validation Steps

This will help us get a jump start on validating your PR by describing the steps to replicate
and validate the expected behavior. (For an example of good validation instructions, check out Bryan's Bouncy Ball PR.)

  1. Make sure all merge request checks have passed (CI/CD).
  2. Pull related branches locally.
  3. Create a DAAC Manager Account and assign it to the ORNL DAAC
  4. Create a user account of any role and assign it to the GHRC DAAC
  5. Log in to the system as a DAAC Manager
  6. Navigate to the user's page and select the user created in Step 4.
  7. Attempt to remove the ORNL DAAC
  8. Verify that it doesn't do anything by checking the developer tools and seeing that it returned a No Privileges error
  9. Attempt to add a DAAC and select GHRC DAAC ( You may have to type it in to get it to appear as an option)
  10. Verify that you are able to successfully add the DAAC
  11. Remove GHRC DAAC
  12. Verify that you are able to successfully remove a DAAC.

Further comments

@ckd002 ckd002 requested a review from a team as a code owner March 24, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant