Skip to content

Updating type on email fields for DAR/DER#343

Merged
camposeddie merged 1 commit intodevelopfrom
EDPUB-1749-Fix-email-validation-in-dar-der
Mar 11, 2026
Merged

Updating type on email fields for DAR/DER#343
camposeddie merged 1 commit intodevelopfrom
EDPUB-1749-Fix-email-validation-in-dar-der

Conversation

@ckd002
Copy link
Contributor

@ckd002 ckd002 commented Mar 11, 2026

Description

When entering an email address into the DAR/DER forms email fields, it would accept any text string rather than validating that the string was in proper email format. This PR updates the type for those fields so that they are properly validated as email addresses.

Linked JIRA Task or Github Issue

JIRA Task: EDPUB-1749

Types of changes

What types of changes does your code introduce to Earthdata Pub (EDPub)?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if adding or updating the existing documentation resources)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide
  • I have updated the CHANGELOG
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Validation Steps

This will help us get a jump start on validating your PR by describing the steps to replicate
and validate the expected behavior. (For an example of good validation instructions, check out Bryan's Bouncy Ball PR.)

  1. Make sure all merge request checks have passed (CI/CD).
  2. Pull related branches locally.
  3. Create a new Data Accession Request
  4. Add a bad email address (I.e. test) to the Contact Info/Principal Investigator/Email field
  5. Click the "Same as Principal Investigator" button in the Data Accession Point of Contact Section
  6. Click the "Save and Continue Editing" Button
  7. Verify that you get the Contact Information - Email must be a valid email address error message on the 2 email fields
  8. Update the email in the Principal Investigator section to be a valid email
  9. Save and Continue Editing
  10. Verify that the error message no longer appears on save

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ckd002 ckd002 requested a review from a team as a code owner March 11, 2026 15:13
@camposeddie camposeddie merged commit 9b35387 into develop Mar 11, 2026
3 checks passed
@camposeddie camposeddie deleted the EDPUB-1749-Fix-email-validation-in-dar-der branch March 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants