Open
Conversation
|
Any news ? It would be neat to have some integrated visualization @enzoruiz |
|
@nmingotti Thank you for awesome feature. But the figure doesn't consider it. The blue bin is not rotated. The code I run is |
jurgensega
pushed a commit
to NSIT/abap-3dbinpacking
that referenced
this pull request
May 23, 2023
nachitox
reviewed
Apr 14, 2025
Comment on lines
+159
to
+163
| x,y,z = item.position | ||
| color = colorList[counter % len(colorList)] | ||
| self._plotCube(axGlob, float(x), float(y), float(z), | ||
| float(item.width), float(item.height), float(item.depth), | ||
| color=color) |
There was a problem hiding this comment.
Suggested change
| x,y,z = item.position | |
| color = colorList[counter % len(colorList)] | |
| self._plotCube(axGlob, float(x), float(y), float(z), | |
| float(item.width), float(item.height), float(item.depth), | |
| color=color) | |
| x,y,z = item.position | |
| width,height,depth = item.get_dimension() | |
| color = colorList[counter % len(colorList)] | |
| self._plotCube(axGlob, float(x), float(y), float(z), | |
| float(width), float(height), float(depth), | |
| color=color) |
(untested) I think that solves nobel6018 issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I have added a simple way to plot a Bin and the contained Items. Besides being nice to see this should help highlight in which cases the algorithm is not working. I apologize If i made some mistakes this is my first pull request. bye