Skip to content

Conversation

@agrawroh
Copy link
Member

Description

This PR bumps up the version of io_opentelemetry_cpp to v1.20.0.


Commit Message: deps: bump up io_opentelemetry_cpp to v1.20.0
Additional Description: Bump up the version of io_opentelemetry_cpp to v1.20.0
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #39182 was opened by agrawroh.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 19, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #39182 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh force-pushed the deps-iot branch 2 times, most recently from 2184044 to 66f3d66 Compare April 26, 2025 02:32
@agrawroh agrawroh marked this pull request as ready for review April 26, 2025 02:52
@agrawroh
Copy link
Member Author

/retest

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@agrawroh
Copy link
Member Author

/retest

@agrawroh
Copy link
Member Author

@phlax I opened the PR upstream and they suggested that the al would fix the issue. I have change this PR to use that as a patch instead (it'll be merged upstream soon). I'll close my other PR.

@agrawroh agrawroh requested a review from phlax April 27, 2025 22:11
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thaks @agrawroh

and thanks for following up upstream, appreciated

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 28, 2025
@phlax phlax merged commit 3e42574 into envoyproxy:main Apr 28, 2025
25 checks passed
jtlisi pushed a commit to jtlisi/envoy that referenced this pull request Apr 28, 2025
This PR bumps up the version of `io_opentelemetry_cpp` to v1.20.0.

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Jacob Lisi <jtlisi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants