API: change style guide to discourage use of "oneof" #30851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark D. Roth <[email protected]>
htuch
approved these changes
Nov 14, 2023
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, merging as API shepherds are in offline agreement.
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Nov 27, 2023
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Jan 24, 2024
…ncf#79)" This reverts commit 5b9bca5. Reverts cncf#79. Now that cncf#78 `go build` CI is in place; this PR brings back the CEL fields. Once `del.dev` domain is fixed, we'll see the CI passing and will be able to merge this PR. Original comment Signed-off-by: Sergii Tkachenko <[email protected]> --- This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. --- Signed-off-by: Sergii Tkachenko <[email protected]>
4 tasks
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Mar 19, 2024
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. Signed-off-by: Sergii Tkachenko <[email protected]> Signed-off-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Mar 27, 2024
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. Signed-off-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Mar 27, 2024
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. Signed-off-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
to sergiitk/xds
that referenced
this pull request
Mar 28, 2024
This PR adds canonical CEL (https://github.com/google/cel-spec/tree/master/proto/cel/expr) fields to `xds.type.v3.CelExpression`. Canonical CEL `cel.expr` was created identical to the `google.api.expr.v1alpha1`, but may be extended in a backward-compatible way. Nuances: 1. The new fields `cel_expr_parsed` and `cel_expr_checked` are added outside of `oneof expr_specifier` per updated policy change: envoyproxy/envoy#30851 2. `option (validate.required) = true` is removed from the `oneof expr_specifier`, so the users may not presume one of the `parsed_expr`, `checked_expr` will be set. Signed-off-by: Sergii Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: API: change style guide to discourage use of "oneof"
Additional Description:
Risk Level: None
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A