Open
Conversation
olahjacobsen
commented
Mar 20, 2026
| const updatePayload: Record<string, unknown> = { | ||
| combinedTiles: isEmpty(updatedCombinedTiles) | ||
| ? FieldValue.delete() | ||
| : updatedCombinedTiles, |
Contributor
Author
There was a problem hiding this comment.
Vi trenger ikke gjøre noe lenger når vi sletter en tile 🤓 Det påvirker ikke isCombinedTiles!
olahjacobsen
commented
Mar 20, 2026
|
|
||
| export type BoardFooter = z.infer<typeof boardFooterSchema> | ||
|
|
||
| export type CombinedTilesDB = z.infer<typeof combinedTilesSchema> |
Contributor
Author
There was a problem hiding this comment.
Opprydding av ubrukte type-aliaser
olahjacobsen
force-pushed
the
remove-old-combinedTiles
branch
from
03feb91 to
f4ae1b5
Compare
olahjacobsen
force-pushed
the
remove-old-combinedTiles
branch
6 times, most recently
from
6859d0e to
44d9ee3
Compare
olahjacobsen
force-pushed
the
remove-old-combinedTiles
branch
from
44d9ee3 to
b9cbaf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ts6(#2359)🥅 Bakgrunn
Vi migrerer bort fra å bruke den komplekse typen "combinedTiles". Nå tar vi tavla over på
isCombinedTiles, som kun er en boolean som forteller tavla-visning om den skal slå sammen alle tiles i boardet til en liste eller ikke.✨ Løsning
combinedTiles.combinedTileser referert til, er i zod schema for å ikke ha noen feilmeldinger på boards som har dette feltet fortsatt. Det skal fjernes etter en migrering som tar vekk denne dataen fra databasedokumentene. Det kommer senere 💅