feat: add GraphQL filter for vehicles at non-virtual stations#850
Closed
feat: add GraphQL filter for vehicles at non-virtual stations#850
Conversation
When the ingestion property include-vehicles-assigned-to-non-virtual-stations is enabled, vehicles at non-virtual stations are no longer filtered during ingestion. This adds a corresponding opt-in filter to the GraphQL API so clients can still exclude those vehicles by default. The new includeVehiclesAtNonVirtualStations argument is available on both the vehicles query and subscription. Its default value is configurable via org.entur.lamassu.graphql.default-include-vehicles-at-non-virtual-stations (defaults to false).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #850 +/- ##
============================================
- Coverage 80.19% 80.06% -0.14%
- Complexity 1521 1530 +9
============================================
Files 204 204
Lines 5702 5745 +43
Branches 371 384 +13
============================================
+ Hits 4573 4600 +27
- Misses 903 912 +9
- Partials 226 233 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ingestion property include-vehicles-assigned-to-non-virtual-stations is enabled, vehicles at non-virtual stations are no longer filtered during ingestion. This adds a corresponding opt-in filter to the GraphQL API so clients can still exclude those vehicles by default.
The new includeVehiclesAtNonVirtualStations argument is available on both the vehicles query and subscription. Its default value is configurable via org.entur.lamassu.graphql.default-include-vehicles-at-non-virtual-stations (defaults to false).