[mob][photos] Trigger immediate local syn after offline permission grant #9175
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d383104c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (isOfflineMode) { | ||
| // Offline onboarding grants permission without explicitly invoking | ||
| // SyncService, so trigger local import right away. | ||
| unawaited(checkAndSync()); |
There was a problem hiding this comment.
In offline onboarding, _onTapOfflineGrantPermission now invokes SyncService.instance.onPermissionGranted() before firing PermissionGrantedEvent, but this listener also calls checkAndSync() when isOfflineMode is true. That means the same permission grant can start a second local import path immediately after (or alongside) SyncService._doSync, causing duplicate full-media scans and, for limited permissions, potentially two overlapping syncAll() runs against the local DB. This adds avoidable startup latency and resource churn right after permission is granted.
Useful? React with 👍 / 👎.
1 participant
Description
Tests