[mob][native] add screensaver #9140
Conversation
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5ffec6c3d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| edition = "2021" | ||
|
|
||
| [lib] | ||
| name = "core" |
There was a problem hiding this comment.
ente_core
The Rust library is declared as name = "core", so cargo ndk will produce libcore.so, but the generated UniFFI Kotlin loader hardcodes findLibraryName(componentName = "ente_core") in mobile/native/android/apps/screensaver/app/src/main/java/io/ente/screensaver/ente/uniffi/ente_core.kt. This mismatch causes UnsatisfiedLinkError when Ente crypto is first invoked (for example during public album URL parsing), so album setup cannot function on a clean build.
Useful? React with 👍 / 👎.
| commandLine( | ||
| "uniffi-bindgen", | ||
| "generate", | ||
| "src/ente_core.udl", |
There was a problem hiding this comment.
generateEnteCoreBindings is configured to run uniffi-bindgen against src/ente_core.udl, but this repo’s UDL file is rust/uniffi/core/src/core.udl. As written, the regeneration task fails immediately, which prevents reproducible binding updates and leaves the checked-in Kotlin FFI stubs prone to drifting from Rust.
Useful? React with 👍 / 👎.
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
| val hasReleaseSigning = keystorePropertiesFile.exists() | ||
|
|
||
| android { | ||
| namespace = "io.ente.screensaver" |
There was a problem hiding this comment.
Let's use io.ente.photos.droid.screensaver?
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
2 participants
Description
Tests