-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[workflow] add release workflow #9131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30428a3083
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| MACOSX_DEPLOYMENT_TARGET: ${{ matrix.platform.os == 'macos-latest' && '10.15' || '' }} | ||
| CMAKE_OSX_DEPLOYMENT_TARGET: ${{ matrix.platform.os == 'macos-latest' && '10.15' || '' }} | ||
| with: | ||
| projectPath: rust/apps/ensu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point Tauri build to a real project path
The desktop job passes projectPath: rust/apps/ensu to tauri-apps/tauri-action, but in this repository there is no rust/apps/ensu tree (repo-wide file search for that prefix returns nothing), so tag runs (ensu-v*) will fail before any desktop artifact can be built or uploaded. This blocks the primary release workflow path introduced by this commit.
Useful? React with 👍 / 👎.
|
|
||
| defaults: | ||
| run: | ||
| working-directory: mobile/native/android/apps/ensu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an existing Android working directory
The Android job sets a default working-directory of mobile/native/android/apps/ensu, but that directory is not present in this repository, so each run step in build-android will error with "No such file or directory" as soon as the job starts. As written, the Android release path cannot execute successfully.
Useful? React with 👍 / 👎.
Description
Tests