[rust] add validation tests for core #8796
Conversation
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
prateekmedia
requested a deployment
to
workflow-security-review
GitHub Actions
Waiting
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
| println!("\n=== RUST→JS Argon2 Test Vector ==="); | ||
| println!("Password: {}", password); | ||
| println!("Salt (hex): fedcba9876543210fedcba9876543210"); | ||
| println!("MemLimit: {}", crypto::argon::MEMLIMIT_INTERACTIVE); | ||
| println!("OpsLimit: {}", crypto::argon::OPSLIMIT_INTERACTIVE); | ||
| println!("Derived Key (b64): {}", key_b64); |
There was a problem hiding this comment.
Let's remove these println statements? Not sure if this is standard pattern @prateekmedia
There was a problem hiding this comment.
To use Codex here, create a Codex account and connect to github.
There was a problem hiding this comment.
To use Codex here, create a Codex account and connect to github.
There was a problem hiding this comment.
To use Codex here, create a Codex account and connect to github.
2 participants
Description
Tests