Skip to content

Deploy to production - Fix 0x00000 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jefflau merged 4 commits into from
May 6, 2019
Merged

Deploy to production - Fix 0x00000 #268

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40d8899
Fix 0x00000.eth
jefflau May 6, 2019
2fc01b3
Remove log
jefflau May 6, 2019
517eacc
Add more readable log
jefflau May 6, 2019
18a3481
Merge pull request #267 from ensdomains/fix-0x00000
jefflau May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/api/registrar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,13 @@ export const getPermanentEntry = async name => {
}
try {
const web3 = await getWeb3()
const namehash = web3.utils.sha3(name)
const namehash = web3.utils.soliditySha3({ type: 'string', value: name })
const { permanentRegistrarRead: Registrar } = await getPermanentRegistrar()
const {
permanentRegistrarController: RegistrarController
} = await getPermanentRegistrarController()
// Returns true if name is available
obj.available = await Registrar.available(namehash).call()
obj.available = await RegistrarController.available(name).call()
// This is used for old registrar to figure out when the name can be migrated.
obj.migrationLockPeriod = parseInt(
await Registrar.MIGRATION_LOCK_PERIOD().call()
Expand All @@ -177,6 +180,7 @@ export const getPermanentEntry = async name => {
obj.nameExpires = new Date(nameExpires * 1000)
}
} catch (e) {
console.log('Error getting permanent registrar entry', e)
obj.error = e.message
} finally {
return obj
Expand Down Expand Up @@ -239,7 +243,7 @@ export const transferOwner = async ({ to, name }) => {
const nameArray = name.split('.')
const labelHash = web3.utils.sha3(nameArray[0])
const account = await getAccount()
const { permanentRegistrar: Registrar } = await getPermanentRegistrar()
const { permanentRegistrarRead: Registrar } = await getPermanentRegistrar()
return () =>
Registrar.safeTransferFrom(account, to, labelHash).send({
from: account
Expand Down