macos: Fix move_mouse #496
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentamassiv
force-pushed
the
macos_move_mouse
branch
27 times, most recently
from
941b57f to
aa230bb
Compare
When I removed the sleeps, it broke the move_mouse function. If the OS did not have enough time to process the simulated mouse move, we need to manually set the location of the following events so they don't change the mouse back to the old location.
…hen the `enigo` struct was created
pentamassiv
force-pushed
the
macos_move_mouse
branch
5 times, most recently
from
cf2da6d to
c21e64a
Compare
pentamassiv
force-pushed
the
macos_move_mouse
branch
from
c21e64a to
13df3b9
Compare
It now returns as soon as it finds the correct keycode. If none is found, it returns a None instead of 0 (keycode for 'A')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I removed the sleeps, it broke the move_mouse function. We need to manually set the location of consecutive events if the OS did not get enough time to process the simulated mouse move. Otherwise they override the new location to the old one.
Fixes #488, #400
Related to #399