linux: x11rb: improve keymap handling #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keymap only had to be generic because it was used by x11 and Wayland and they had different types for the keycodes. Since keymap is no longer used by Wayland, there is no need for generics
…s uses with its code
8 modifiers are often used, buth there can actually be 32 modifiers
Fewer elements of the iterator get copied, because only elements that passed the filter get copied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until recently, the keymap module was used for the wayland and x11rb features. The code diverged and now I think it doesn't make that much sense to use the same keymap module anymore.
This PR works on improving the keymap handling with x11rb. The goal is to get the state from the X11 server so it is always in sync