Add initial E+ 10x test files to the repo#27
Conversation
Myoldmopar
left a comment
There was a problem hiding this comment.
OK, the test files now run from the CMake structure. For example:
$ ctest -R 10x_RefBldgFull
Test project /home/edwin/Projects/energyplus/repos/energy-plus/builds/10xsuite/dc
Start 1413: integration.10x_RefBldgFullServiceRestaurantNew2004_Chicago
1/1 Test #1413: integration.10x_RefBldgFullServiceRestaurantNew2004_Chicago ... Passed 18.39 sec
100% tests passed, 0 tests failed out of 1
Total Test time (real) = 18.43 sec
I made a few comments that we need to resolve before we merge this in. Please let me know if you have issues with them.
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_VetBuilding.idf VetBuilding.epw) | ||
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_100_zones_with_HVAC_London_Db.idf 100_zones_London.Gatwick.037760_IWEC.epw) | ||
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_Bay_Gerrard_WWR_82_Toronto.idf Bay_CAN_ON_Toronto.716240_CWEC.epw) | ||
| #ADD_SIMULATION_TEST(IDF_FILE Bay_Gerrard_WWR_82_Toronto.idf.idf VetBuilding.epw) |
There was a problem hiding this comment.
@XuanLuoLBL It kinda looked like this line was an unintentional addition. The file is already added as a test in the line above, and the epw sorta doesn't match. Can you verify, and if so go ahead and remove this line? Thanks!
There was a problem hiding this comment.
this was a typo. fixed.
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgStripMallNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw) | ||
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgSuperMarketNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw) | ||
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgWarehouseNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw) | ||
| ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_VetBuilding.idf VetBuilding.epw) |
There was a problem hiding this comment.
So with any of these non-TMY weather data files, we need to be sure we are able to have them posted. @XuanLuoLBL can you just try changing all these to Chicago and running them all and making sure things are OK? It would be great if we could just avoid any issues by using our standard weather data files rather than weather data from other sources.
There was a problem hiding this comment.
@Myoldmopar I run these four large files with the Chicago epw. Three of them work as modified in the commits, one still has some severe error so currently removed. thanks for checking.
update to 9.1
Sync the code on 05/03/2019
Pull request overview
This is the initial addition of test files for the 10x suite. Definitely more to come but this will be a start.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.