Skip to content

Add initial E+ 10x test files to the repo#27

Open
Myoldmopar wants to merge 29 commits intodevelopfrom
test-suite
Open

Add initial E+ 10x test files to the repo#27
Myoldmopar wants to merge 29 commits intodevelopfrom
test-suite

Conversation

@Myoldmopar
Copy link
Copy Markdown

Pull request overview

This is the initial addition of test files for the 10x suite. Definitely more to come but this will be a start.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
    • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
    • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
    • NewFeature: This pull request includes code to add a new feature to EnergyPlus
    • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
    • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add to input rules file for interfaces
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Required documentation updates?
  • ExpandObjects changes?
  • If output changes, including tabular output structure, add to output rules file for interfaces

Copy link
Copy Markdown
Author

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the test files now run from the CMake structure. For example:

$ ctest -R 10x_RefBldgFull
Test project /home/edwin/Projects/energyplus/repos/energy-plus/builds/10xsuite/dc
    Start 1413: integration.10x_RefBldgFullServiceRestaurantNew2004_Chicago
1/1 Test #1413: integration.10x_RefBldgFullServiceRestaurantNew2004_Chicago ...   Passed   18.39 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =  18.43 sec

I made a few comments that we need to resolve before we merge this in. Please let me know if you have issues with them.

Comment thread testfiles/10xSuite/CMakeLists.txt Outdated
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_VetBuilding.idf VetBuilding.epw)
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_100_zones_with_HVAC_London_Db.idf 100_zones_London.Gatwick.037760_IWEC.epw)
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_Bay_Gerrard_WWR_82_Toronto.idf Bay_CAN_ON_Toronto.716240_CWEC.epw)
#ADD_SIMULATION_TEST(IDF_FILE Bay_Gerrard_WWR_82_Toronto.idf.idf VetBuilding.epw)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuanLuoLBL It kinda looked like this line was an unintentional addition. The file is already added as a test in the line above, and the epw sorta doesn't match. Can you verify, and if so go ahead and remove this line? Thanks!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a typo. fixed.

Comment thread testfiles/10xSuite/CMakeLists.txt Outdated
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgStripMallNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgSuperMarketNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_RefBldgWarehouseNew2004_Chicago.idf EPW_FILE USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw)
ADD_SIMULATION_TEST(IDF_FILE 10xSuite/10x_VetBuilding.idf VetBuilding.epw)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with any of these non-TMY weather data files, we need to be sure we are able to have them posted. @XuanLuoLBL can you just try changing all these to Chicago and running them all and making sure things are OK? It would be great if we could just avoid any issues by using our standard weather data files rather than weather data from other sources.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Myoldmopar I run these four large files with the Chicago epw. Three of them work as modified in the commits, one still has some severe error so currently removed. thanks for checking.

Sync the code on 05/03/2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants