Can no longer mark a failed meetup as completed

[echevrier]

Since paritytech/substrate#11927 changes, the storage don't persist when a call return an error. See paritytech/substrate#11533 (comment)
So

pallets/ceremonies/src/lib.rs

Line 597 in 615c292

<IssuedRewards<T>>::insert((cid, cindex), meetup_index, ());

will not be saved.
The test claim_rewards_error_results_in_meetup_marked_as_completed fails at

pallets/ceremonies/src/tests.rs

Line 1040 in 615c292

assert!(IssuedRewards::<TestRuntime>::contains_key((cid, cindex), 1));

[echevrier]

@clangenb Before fixing this, I would like to understand the purpose of IssuedRewards<T>.

There is no "completed meetup". IssuedRewards<T> is used to ensure that the reward is issued only one time, even if claim_rewards is called multiple times:

pallets/ceremonies/src/lib.rs

Line 560 in 615c292

if <IssuedRewards<T>>::contains_key((cid, cindex), meetup_index) {

The key is inserted when the rewards have been successfully issued:

pallets/ceremonies/src/lib.rs

Line 1893 in 615c292

<IssuedRewards<T>>::insert((cid, cindex), meetup_idx, ());

and in the registration phase, when we cannot get the participants who are eligible for the reward:

pallets/ceremonies/src/lib.rs

Line 597 in 615c292

<IssuedRewards<T>>::insert((cid, cindex), meetup_index, ());

What if claim_reward fails for other reasons?
What if claim_reward is never called?

If the problem is only at

pallets/ceremonies/src/lib.rs

Line 597 in 615c292

<IssuedRewards<T>>::insert((cid, cindex), meetup_index, ());

, can we emit an event in this case and the off-chain world will call an update of IssuedRewards<T> ?