Skip to content

Add isort and black to scripts/check #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
florimondmanca wants to merge 5 commits into from
+4 −2
Closed

Add isort and black to scripts/check #144

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a79021b
Add isort and black to scripts/check
florimondmanca Aug 8, 2020
cf90b33
Merge branch 'master' into more-checks
florimondmanca Aug 9, 2020
c0c906f
isort: skip sync generated files
florimondmanca Aug 9, 2020
0f92078
Fix exclude flags
florimondmanca Aug 9, 2020
96bce25
Merge branch 'master' into more-checks
florimondmanca Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ export SOURCE_FILES="httpcore tests"

set -x

${PREFIX}isort --check --diff --skip-glob 'httpcore/_sync/*' --skip-glob 'tests/sync_tests/*' --project=httpcore $SOURCE_FILES
${PREFIX}black --check --diff --exclude 'httpcore/_sync/.*|tests/sync_tests/.*' --target-version=py36 $SOURCE_FILES
${PREFIX}mypy --ignore-missing-imports httpcore
scripts/unasync --check
4 changes: 2 additions & 2 deletions scripts/lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export SOURCE_FILES="httpcore tests"
set -x

${PREFIX}autoflake --in-place --recursive $SOURCE_FILES
${PREFIX}isort --project=httpcore $SOURCE_FILES
${PREFIX}black --exclude 'httpcore/_sync/.*' --exclude 'tests/sync_tests/.*' --target-version=py36 $SOURCE_FILES
${PREFIX}isort --skip-glob 'httpcore/_sync/*' --skip-glob 'tests/sync_tests/*' --project=httpcore $SOURCE_FILES
${PREFIX}black --exclude 'httpcore/_sync/.*|tests/sync_tests/.*' --target-version=py36 $SOURCE_FILES
Copy link
Copy Markdown
Contributor

@JayH5 JayH5 Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think the .* is necessary but eh 🤷‍♂️. Would be nice if black used globs instead of regexes.


# Run unasync last because its `--check` mode is not aware of code formatters.
# (This means sync code isn't prettified, and that's mostly okay.)
Expand Down