Skip to content

Conversation

@buu700
Copy link
Contributor

@buu700 buu700 commented Oct 17, 2017

Small bug that I just noticed snuck in shortly before #5296 was merged.

@kripken
Copy link
Member

kripken commented Oct 17, 2017

Did this not break any tests? We need to add one if so.

@buu700
Copy link
Contributor Author

buu700 commented Oct 17, 2017

Nope, don't think so. The only effect is that intArrayToString in arrayUtils.js would always behave as though ASSERTIONS is false. (This isn't really SINGLE_FILE-specific, but was introduced by that PR.)

@kripken
Copy link
Member

kripken commented Oct 24, 2017

The ci error was transient it seems, restarting fixed it.

@kripken kripken merged commit 21ea73f into emscripten-core:incoming Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants