Skip to content

Fix lsan.test_dylink_iostream after #25449 #25474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Oct 2, 2025
Merged

Fix lsan.test_dylink_iostream after #25449 #25474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@ jobs:
lsan.test_dlfcn_basic
lsan.test_pthread_create
lsan.test_pthread_exit_main_stub
lsan.test_dylink_iostream
ubsan.test_externref_emjs_dynlink"
- freeze-cache
- run-tests:
Expand Down
5 changes: 3 additions & 2 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3096,8 +3096,9 @@ def run(options, linker_args):
# This is not normally a problem except in the case of -sMAIN_MODULE=1 where
# the duplicate library would result in duplicate symbols.
for s in system_libs:
if s not in linker_args:
linker_args.append(s)
if s.startswith('-l') and s in linker_args:
continue
linker_args.append(s)

js_syms = {}
if (not settings.SIDE_MODULE or settings.ASYNCIFY) and not shared.SKIP_SUBPROCS:
Expand Down