Skip to content

[MODULARIZE=instance] Allow incoming wasmMemory #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 15, 2025
Merged

[MODULARIZE=instance] Allow incoming wasmMemory #24343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,7 @@ jobs:
instance.test_dyncall*
instance.test_em_asm*
instance.test_embind*
instance.test_module_wasm_memory
esm_integration.test_fs_js_api*
esm_integration.test_inlinejs3
esm_integration.test_embind_val_basics
Expand Down
4 changes: 0 additions & 4 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,10 +830,6 @@ def limit_incoming_module_api():
exit_with_error('MODULARIZE=instance is not compatible with -sASYNCIFY_LAZY_LOAD_CODE')
if options.use_preload_plugins or len(options.preload_files):
exit_with_error('MODULARIZE=instance is not compatible with --embed-file/--preload-file')
if 'INCOMING_MODULE_JS_API' in user_settings:
for s in ['wasmMemory', 'INITIAL_MEMORY']:
if s in settings.INCOMING_MODULE_JS_API:
exit_with_error(f'{s} cannot be in INCOMING_MODULE_JS_API in MODULARIZE=instance mode')

if options.oformat in (OFormat.WASM, OFormat.BARE):
if options.emit_tsd:
Expand Down