Skip to content

Reduce non-highmem browser testing#23911

Merged
dschuff merged 5 commits into
emscripten-core:mainfrom
dschuff:browser
Mar 12, 2025
Merged

Reduce non-highmem browser testing#23911
dschuff merged 5 commits into
emscripten-core:mainfrom
dschuff:browser

Conversation

@dschuff

@dschuff dschuff commented Mar 12, 2025

Copy link
Copy Markdown
Member

This reduces the number of tests run in the "default" browser test modes
(i.e. non-2g 32bit and non-4g 64-bit). The idea is that the set of edge
cases covered by the 2g and 4g modes is basically a superset of those
covered by the default cases. Tests that are disabled in the 2g and 4g
modes are still run in the default modes.

dschuff added 2 commits March 12, 2025 21:25
This reduces the number of tests run in the "default" browser test modes
(i.e. non-2g 32bit and non-4g 64-bit). The idea is that the set of edge
cases covered by the 2g and 4g modes is basically a superset of those
covered by the default cases. Tests that are disabled in the 2g and 4g
modes are still run in the default modes.
@dschuff

dschuff commented Mar 12, 2025

Copy link
Copy Markdown
Member Author

This does still keep some tests running in the default modes, just to make sure that no tests are skipped entirely.
It's not awesome that the list of tests that we still run in the default mode is duplicated manually from the set of tests marked with no_2gb and no_4gb. Maybe if we want to keep this optimization longer-term we could do something about that, not sure.

@dschuff dschuff requested review from kripken and sbc100 March 12, 2025 21:30
Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments and maybe TODO to restore some day?

@dschuff dschuff enabled auto-merge (squash) March 12, 2025 22:08
@dschuff

dschuff commented Mar 12, 2025

Copy link
Copy Markdown
Member Author

test_2gb_fail, test_4gb_fail and test_2gb are failing here in test-browser-chrome-wasm64. Were they working before?

@dschuff

dschuff commented Mar 12, 2025

Copy link
Copy Markdown
Member Author

oh nevermind, they were skipped before.

@sbc100

sbc100 commented Mar 12, 2025

Copy link
Copy Markdown
Collaborator

test_2gb_fail, test_4gb_fail and test_2gb are failing here in test-browser-chrome-wasm64. Were they working before?

The 4gb_fail test looks like it was deliberately skipped (your removed that line).

@dschuff dschuff merged commit 0029627 into emscripten-core:main Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants