-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update libcxx and libcxxabi to LLVM 18.1.2 #21638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 17 commits
c49d831
e9a39c1
31ac683
6a0909e
df9af64
2bd7c67
e508f3d
8d51927
78af7d4
72283aa
e4d4bc7
39c27d1
047d130
f628139
5eeb965
57dbfba
3504d7c
942b0d4
5f265c7
1fbe318
a4ec944
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,9 +102,17 @@ var LibraryExceptions = { | |
| } | ||
| }, | ||
|
|
||
| __cxa_init_primary_exception__deps: ['$ExceptionInfo'], | ||
| __cxa_init_primary_exception: (ptr, type, destructor) => { | ||
| #if EXCEPTION_DEBUG | ||
| dbg('__cxa_init_primary_exception: ' + [ptrToString(ptr), type, ptrToString(destructor)]); | ||
| #endif | ||
| return ptr; | ||
| }, | ||
|
|
||
| // Here, we throw an exception after recording a couple of values that we need to remember | ||
| // We also remember that it was the last exception thrown as we need to know that later. | ||
| __cxa_throw__deps: ['$ExceptionInfo', '$exceptionLast', '$uncaughtExceptionCount'], | ||
| __cxa_throw__deps: ['$exceptionLast', '$uncaughtExceptionCount', '__cxa_init_primary_exception'], | ||
|
||
| __cxa_throw: (ptr, type, destructor) => { | ||
| #if EXCEPTION_DEBUG | ||
| dbg('__cxa_throw: ' + [ptrToString(ptr), type, ptrToString(destructor)]); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function looks like it could be a native symbol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now that this is not being used in
__cxa_throwI think we can use the native version of this. But if I delete thistest_dylink_exceptions_try_catch_6errors out withI guess I need to add this symbol to some list of exported functions...? Can you help me where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you add
__cxa_init_primary_exceptiontocxa_exception_emscripten.cppthat should do the trick. No need to export anything I would hope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was added in llvm/llvm-project#65534
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: a4ec944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbc100 from the
compile_commands.json:compile_commands.json
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbc100
I thought so too, but the compile command @mzukovec gave didn't have any EH options, strange.
I guess they are the only functions called from libc++ where the code is not guarded with
#ifndef _LIBCPP_HAS_NO_EXCEPTIONS. Apparently all uses of__cxa_init_primary_exceptionsare guarded with#ifndef _LIBCPP_HAS_NO_EXCEPTIONS, so not sure what's causing the issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzukovec Can you possibly share the
itkPoolMultiThreader.cxx.oanditkPoolMultiThreader.cxx?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
itkPoolMultiThreader.zip
Link to the used ITK revision in case it's needed later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #22027 will fix this. Thanks for the report!