Skip to content

Conversation

@aheejin
Copy link
Member

@aheejin aheejin commented Mar 13, 2024

No description provided.

@aheejin aheejin requested a review from sbc100 March 13, 2024 17:14
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (after emsdk PR lands)

@aheejin
Copy link
Member Author

aheejin commented Mar 14, 2024

3.1.56 turned out to be broken. Some context is in discussions in emscripten-core/emsdk#1353. It looks we have to do a new release that contains #21523 and #21515, which will be marked as 3.1.57. Will land this anyway given that 3.1.56 has been (sadly) effectively shipped.

@aheejin aheejin merged commit d0c4878 into main Mar 14, 2024
@aheejin aheejin deleted the version_3.1.56 branch March 14, 2024 16:39
aheejin added a commit to aheejin/emscripten that referenced this pull request Mar 15, 2024
After emscripten-core#21518 landed, the previous 3.1.56 release (emscripten-core#1353) turned out to
be broken so we replaced 3.1.56 with the new one (emscripten-core#1360). So here to be
precise we update the date of the new 3.1.56 release.
aheejin added a commit that referenced this pull request Mar 15, 2024
After #21518 landed, the previous 3.1.56 release
(emscripten-core/emsdk#1353) turned out to be
broken so we replaced 3.1.56 with the new one
(emscripten-core/emsdk#1360). So here to be
precise we update the date of the new 3.1.56 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants