Skip to content

Avoid use of port 8088 in socket tests. NFC #21512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Mar 11, 2024
Merged

Avoid use of port 8088 in socket tests. NFC #21512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/websocket/nodejs_websocket_echo_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function hexDump(bytes) {
}

var decoder = new TextDecoder('utf-8');
var port = 8088;
var port = 8089;
var ws = require('ws');
var wss = new ws.WebSocketServer({ port: port });
console.log('WebSocket server listening on ws://localhost:' + port + '/');
Expand Down
2 changes: 1 addition & 1 deletion test/websocket/test_websocket_send.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ int main()
EmscriptenWebSocketCreateAttributes attr;
emscripten_websocket_init_create_attributes(&attr);

const char *url = "ws://localhost:8088/";
const char *url = "ws://localhost:8089/";
attr.url = url;
attr.protocols = "binary,base64"; // We don't really use a special protocol on the server backend in this test, but check that it can be passed.

Expand Down