Skip to content

Avoid generating empty statement in receiveI64ParamAsI53 #21487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 4 commits into from
Mar 11, 2024
Merged

Avoid generating empty statement in receiveI64ParamAsI53 #21487

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c9eeaf
Avoid generating empty statement in receiveI64ParamAsI53
kainino0x Mar 7, 2024
ca268b4
Merge branch 'main' into receiveI64ParamAsI53-warning
kainino0x Mar 7, 2024
f8b42a5
Merge branch 'main' into receiveI64ParamAsI53-warning
kainino0x Mar 8, 2024
ea72c67
Merge branch 'main' into receiveI64ParamAsI53-warning
kainino0x Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parseTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,14 +911,14 @@ function defineI64Param(name) {


function receiveI64ParamAsI53(name, onError, handleErrors = true) {
var errorHandler = handleErrors ? `if (isNaN(${name})) return ${onError}` : '';
var errorHandler = handleErrors ? `if (isNaN(${name})) { return ${onError}; }` : '';
Copy link
Collaborator

@sbc100 sbc100 Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the extra braces needed here?

Copy link
Collaborator Author

@kainino0x kainino0x Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I just thought it felt safer in code that's being pasted together. Like, in case onError has a semicolon in it or something. Should get minified so it seems OK.

if (WASM_BIGINT) {
// Just convert the bigint into a double.
return `${name} = bigintToI53Checked(${name});${errorHandler};`;
return `${name} = bigintToI53Checked(${name});${errorHandler}`;
}
// Convert the high/low pair to a Number, checking for
// overflow of the I53 range and returning onError in that case.
return `var ${name} = convertI32PairToI53Checked(${name}_low, ${name}_high);${errorHandler};`;
return `var ${name} = convertI32PairToI53Checked(${name}_low, ${name}_high);${errorHandler}`;
}

function receiveI64ParamAsI53Unchecked(name) {
Expand Down