Skip to content

Fix python error when build with audio worklets enabled since #20881 #21340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 6 commits into from
Feb 21, 2024
+1 −1
Merged

Fix python error when build with audio worklets enabled since #20881 #21340

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f25599
[audio worklet] Fix python error when build with audio worklets enabl…
FrancoisRecisio Feb 14, 2024
d2bb3ba
Try to trigger failed tests
FrancoisRecisio Feb 15, 2024
6e59213
Add a specific test
FrancoisRecisio Feb 15, 2024
30eca4d
Add a specific test (another try)
FrancoisRecisio Feb 15, 2024
bbd28af
Fix again
FrancoisRecisio Feb 15, 2024
fb4f178
Fix test
FrancoisRecisio Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5817,6 +5817,7 @@ def test_audio_worklet(self, args):
if '-sMEMORY64' in args and is_firefox():
self.skipTest('https://github.com/emscripten-core/emscripten/issues/19161')
self.btest_exit('webaudio/audioworklet.c', args=['-sAUDIO_WORKLET', '-sWASM_WORKERS'] + args)
self.btest_exit('webaudio/audioworklet.c', args=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-sSTRICT'] + args)
Copy link
Collaborator

@sbc100 sbc100 Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add -sSTRICT to the line above?

Copy link
Collaborator

@sbc100 sbc100 Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if you prefer you could add strict key the @parameterized dictionary above.


# Tests that posting functions between the main thread and the audioworklet thread works
@parameterized({
Expand Down
1 change: 0 additions & 1 deletion tools/feature_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ class Feature(IntEnum):
},
Feature.GLOBALTHIS: {
'chrome': 71,
'edge': 79,
'firefox': 65,
'safari': 120100,
'node': 120000,
Expand Down