Remove dependency on assert from SAFE_HEAP #20696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of emscripten-core#20592, `assert` is no longer defined in release builds in STRICT mode, but its still possible to use SAFE_HEAP in this configuration. Instead of complicating the definition of `assert` to match `preamble_minimal.js` this change instead removed the dependency of SAFE_HEAP on the assert function. This fixes the `core2s.test_module_wasm_memory` which is currently failing on the emscripten-releases tree.
sbc100
force-pushed
the
fix_safe_heap
branch
from
e38b58e to
97a7b39
Compare
sbc100
changed the title
kripken
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #20592,
assertis no longer defined in release builds in STRICTmode, but its still possible to use SAFE_HEAP in this configuration.
Instead of complicating the definition of
assertto matchpreamble_minimal.jsthis change instead removed the dependency ofSAFE_HEAP on the assert function.
This fixes the
core2s.test_module_wasm_memorywhich is currently failing on the emscripten-releases tree.