jsifier: Add explicit error messages for missing/native alias targets #19042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
enfore_alias_rules
branch
2 times, most recently
from
e2af8ce to
349f1a0
Compare
sbc100
commented
Mar 22, 2023
| // it is a BigInt. Otherwise, we legalize into pairs of i32s. | ||
| function defineI64Param(name) { | ||
| if (WASM_BIGINT) { | ||
| return `/** @type {!BigInt} */ ${name}`; |
Collaborator
Author
There was a problem hiding this comment.
This was removed because otherwise closure generates errors like this one:
/tmp/emscripten_temp_16el3cc_/hello_world.js:20729:6: WARNING - [JSC_TYPE_MISMATCH] assignment
found : number
required: BigInt
20729| timeout = Number(timeout);
This was happening for any function that used receiveI64ParamAsI53Unchecked which is currently just glClientWaitSync and glWaitSync.
sbc100
force-pushed
the
enfore_alias_rules
branch
from
349f1a0 to
f4be7f8
Compare
Followup to #19033. Updating the `test_closure_full_js_library` to include webgl2 caused a lot of `JSC_REFERENCE_BEFORE_DECLARE` closure errors. This is because we had JS aliases who's target was defined both in JS and in native code. In this case the jsifier chooses not to include the JS version but the location where the aliases are declared in the output comes before the native symbols are declared. To fix this I removed the native aliases from webgl2.c, since these exact same aliases already exist in library_webgl.js. This think is also more correct since it means that the `emscripten_xx` wrappers are defined fully in JS and are not effected by definitions in native code (which is the whole point of them I believe).
sbc100
force-pushed
the
enfore_alias_rules
branch
from
f4be7f8 to
45ed231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #19033.
Updating the
test_closure_full_js_libraryto include webgl2 caused a lot ofJSC_REFERENCE_BEFORE_DECLAREclosure errors.This is because we had JS aliases who's target was defined both in JS and in native code. In this case the jsifier chooses not to include the JS version but the location where the aliases are declared in the output comes before the native symbols are declared.
To fix this I removed the native aliases from webgl2.c, since these exact same aliases already exist in library_webgl.js.
This think is also more correct since it means that the
emscripten_xxwrappers are defined fully in JS and are not effected by definitions in native code (which is the whole point of them I believe).