Use __attribute__(export_name) over EMSCRIPTEN_KEEPALIVE in EM_JS macro
#16149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like this requires an llvm-side changes since export_name is not currently supported for non-function symbols. |
…S` macro The `EMSCRIPTEN_KEEPALIVE` macro relies on `attribute((used))` which works slightly differently under emscripten (`wasm32-unknown-emscripten`) compared to other triples. This change avoids `EMSCRIPTEN_KEEPALIVE` here in favor of the `export_name` attribute which is more precise and correct although not (yet) suitable for us in `EMSCRIPTEN_KEEPALIVE` itself (We would need something like https://reviews.llvm.org/D76547 to make that work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EMSCRIPTEN_KEEPALIVEmacro relies onattribute((used))whichworks slightly differently under emscripten
(
wasm32-unknown-emscripten) compared to other triples.This change avoids
EMSCRIPTEN_KEEPALIVEhere in favor of theexport_nameattribute which is more precise and correct although not(yet) suitable for us in
EMSCRIPTEN_KEEPALIVEitself (We would needsomething like https://reviews.llvm.org/D76547 to make that work).