Skip to content

use a thread local CharsetDecode instance to prevent IllegalStateException #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022
Merged

use a thread local CharsetDecode instance to prevent IllegalStateException #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mqtt_jmeter/src/main/java/net/xmeter/samplers/mqtt/hivemq/HiveMQTTConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class HiveMQTTConnection implements MQTTConnection {
private static final Logger logger = Logger.getLogger(HiveMQTTConnection.class.getCanonicalName());

private static final Charset charset = Charset.forName("UTF-8");
private static final CharsetDecoder decoder = charset.newDecoder();
private static ThreadLocal<CharsetDecoder> decoder = ThreadLocal.withInitial(() -> charset.newDecoder());

private final Mqtt3BlockingClient client;
private final String clientId;
Expand Down Expand Up @@ -112,7 +112,7 @@ private void handlePublishReceived(Mqtt3Publish received) {

private String decode(ByteBuffer value) {
try {
return decoder.decode(value).toString();
return decoder.get().decode(value).toString();
} catch (CharacterCodingException e) {
throw new RuntimeException(new MQTTClientException("Failed to decode", e));
}
Expand Down