Skip to content

Big sync PR#147

Merged
JaylinYu merged 15 commits into
mainfrom
jaylin/nanosdk
Mar 23, 2023
Merged

Big sync PR#147
JaylinYu merged 15 commits into
mainfrom
jaylin/nanosdk

Conversation

@JaylinYu
Copy link
Copy Markdown
Member

The supplemental part is not finished yet

@JaylinYu JaylinYu requested review from alvin1221 and wanghaEMQ March 22, 2023 12:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 16.89% and project coverage change: +6.88 🎉

Comparison is base (c0eb36f) 54.67% compared to head (bab29ba) 61.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   54.67%   61.56%   +6.88%     
==========================================
  Files          95       99       +4     
  Lines       25307    26440    +1133     
==========================================
+ Hits        13837    16278    +2441     
+ Misses      11470    10162    -1308     
Impacted Files Coverage Δ
src/core/message.c 84.79% <0.00%> (-0.54%) ⬇️
src/core/panic.c 0.00% <0.00%> (ø)
src/mqtt/protocol/mqtt/mqtt_client.c 0.00% <0.00%> (ø)
src/mqtt/protocol/mqtt/mqtt_quic.c 0.00% <0.00%> (ø)
src/mqtt/protocol/mqtt/mqttv5_client.c 0.00% <0.00%> (ø)
src/mqtt/transport/tcp/mqtt_tcp.c 0.67% <0.00%> (-0.01%) ⬇️
src/mqtt/transport/tls/mqtt_tls.c 0.67% <0.00%> (-0.01%) ⬇️
src/platform/posix/posix_clock.c 60.00% <0.00%> (-32.31%) ⬇️
src/platform/posix/posix_file.c 60.13% <0.00%> (+29.30%) ⬆️
src/supplemental/mqtt/mqtt_public.c 16.61% <0.00%> (-1.67%) ⬇️
... and 6 more

... and 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread include/nng/supplemental/util/platform.h Outdated
Comment thread src/mqtt/protocol/mqtt/mqtt_quic.c Outdated
alvin1221
alvin1221 previously approved these changes Mar 23, 2023
@JaylinYu JaylinYu requested a review from alvin1221 March 23, 2023 08:16
@JaylinYu JaylinYu merged commit 1f74bff into main Mar 23, 2023
@JaylinYu JaylinYu deleted the jaylin/nanosdk branch March 23, 2023 10:25
@wanghaEMQ
Copy link
Copy Markdown
Member

demo is also not supported yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants