Added edge-light and workerd conditions
#3215
Conversation
🦋 Changeset detectedLatest commit: 8fb4d9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| "import": "./dist/emotion-cache.development.edge-light.cjs.mjs", | ||
| "default": "./dist/emotion-cache.development.edge-light.cjs.js" | ||
| }, | ||
| "worker": { |
There was a problem hiding this comment.
Do other libraries not use their browser builds for Service Workers?
There was a problem hiding this comment.
No idea, there are no great guidelines for this and various tools are not exactly overly consistent and explicit when it comes to differentiating between browser and worker builds.
Webpack 5 docs have always suggested using the worker condition for (web)workers... so that's what we went with here.
But I'm also not sure if I have understood the intention behind your question. Could you elaborate?
There was a problem hiding this comment.
What we found in the past is that some tools would pick up the browser condition when targeting workers so we had to use some earlier condition (worker) to "shadow" over the browser condition. Ideally, it would just fall through to the default condition and use that
There was a problem hiding this comment.
Just wondering if it makes more sense to use browser builds. But if the browser builds access the DOM, they're not suited for Service Workers. Given that there's little guidance/standardization around this topic we'll probably just have to find out.
There was a problem hiding this comment.
Ye, so that's the main distinction that we have here - #is-browser could be called #can-use-dom. That's the only thing we care about atm. So we can't use the browser builds because they assume being able to access DOM
Next.js plans to migrate away from using
workercondition because that pulls in React browser builds... so I have been asked to add their dedicated condition.