Implement the plugin as a babel macro#142
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 89.08% 90.15% +1.07%
==========================================
Files 18 22 +4
Lines 632 701 +69
Branches 145 167 +22
==========================================
+ Hits 563 632 +69
Misses 56 56
Partials 13 13
Continue to review full report at Codecov.
|
tkh44
approved these changes
Jul 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Allow people to use the plugin as a babel macro.
Why:
#132
How:
Abstract stuff in
babel.jsChecklist:
I based this off #130 so I could make the react styled import
emotion/react/macro(we need to have separate macros for each runtime version ofstyledsince we have to add imports to the runtime, I'm gonna abstract this away so it won't have a big maintenance cost)This is very work in progress and it will have to change a bunch.The only thing that we can't do with a babel macro is the css prop. (I think)
commonjs requiresbabel-macrosonly supports importing defaults with commonjs so just supporting this forstyleddoesn't seem worth it imo. Throw an error if the macro is imported with commonjsemotion/macro,emotion/react/macro,emotion/vue/macroCloses #132
Closes #112
Just a note: #130 should be merged before this