Make data-vaul-no-drag work if any parent matches#267
Merged
Conversation
|
@arsaizdihar is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
emilkowalski
approved these changes
Feb 11, 2024
|
this still not working with Inputs fields |
This was referenced Apr 29, 2024
|
Can someone please provide an example on how to use this attribute |
Contributor
Author
You just need to add attribute |
|
I did everything what you suggested @arsaizdihar but I can still drag the drawer, any ideas? thanks! |
I did as @arsaizdihar said and it worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
data-vaul-no-dragonly worked if the dragged element is exactly the element that has the attribute. The expected behavior is it works if any of the parent (usingelement.closest) has the attribute. Fixes #266