Per-widget style #7667
Per-widget style #7667
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7667-widgetstyle View snapshot changes at kitdiff |
lucasmerlin
left a comment
lucasmerlin
left a comment
There was a problem hiding this comment.
Nice! Seems like the checkbox is missing in menus for some reason (see the failed snapshot test: https://rerun-io.github.io/kitdiff/?url=https://github.com/emilk/egui/pull/7667)
crates/egui/src/widgets/checkbox.rs
Outdated
| pos2(rect.left() + icon_width / 2.0, rect.center().y), | ||
| Vec2::splat(style.size), |
There was a problem hiding this comment.
It's a bit confusing that you use icon_width and style.size, when they are the same thing. Maybe size should also be renamed to icon_size or checkbox_size.
|
The check script result in 3 snapshot diff : 2 are the corner of drag value, but Kitdiff show no difference between old/new so I think it's due to linux and x11, and the last diff is in the fractal clock where a single pixel is a bit brighter but again I think it's linux and x11 |
2 participants
Implementation of the per-widget style of the action plan to add better styling option to egui