Add option scrolling_zooms for mouse wheel to zoom instead of scroll inside a Scene container
#7666
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added feature to allow mousewheel scroll input to zoom a scene rather than pan it (i.e. for an image viewer or other application). This addresses Issue emilk#7650
Fixed compilation errors.
Fixed compiler error
Adding horizontal and vertical scroll
Included scroll zoom speed
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/7666-patch-1 View snapshot changes at kitdiff |
Tristan117
changed the title
scrolling_zooms for mouse wheel to zoom instead of scroll inside a Scene container
Tristan117
changed the title
scrolling_zooms for mouse wheel to zoom instead of scroll inside a Scene containerscrolling_zooms for mouse wheel to zoom instead of scroll inside a Scene container
Author
|
All tests passing. Took a number of additional setup steps (install pngcrush, set options.threshold(OsThreshold::new(0.0).windows(2.1)) for the Bézier Curve demo) to get them working in Windows. |
Fixed compilation errors. Update scene.rs Fixed compiler error Update scene.rs Adding horizontal and vertical scroll
Included scroll zoom speed
trying to fix scroll_zoom_speed Trying to fix scroll_zoom_speed This should fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egui::Scene#7650This feature allows building image viewers and similar applications using a Scene container where the desired mouse wheel input without a modifier is to zoom rather than scroll/pan.
Alternatives considered:
Doesn't work because Modifiers:NONE never matches to anything (and therefore disables mouse wheel zoom globally.
Refactoring this to provide a different option per container is a large amount of work and does not seem to be a use case that is likely to be used outside of Scene
The logic used inside Scene to achieve this is fairly simple and only adds one extra dependency on input_options.scroll_zoom_speed to ensure that the zoom speed setting change is consistent across the application
tested as part of my application
run ./scripts/check.sh