IME enabled on web #247
Closed
IME enabled on web #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e8d9273.
Closed
Owner
|
This is awesome work, but there are a few kinks to iron out! Most noticeably: when I click anywhere on the web page, the egui interface slides down to the lower half of the screen. This happens both on firefox on my macbook and on safari on my iphone. EDIT here is a fix: 41a3bb6 |
emilk
reviewed
Mar 24, 2021
emilk
requested changes
Mar 24, 2021
Owner
|
Again, really amazing work - thanks you so much for this! ❤️ If you would like some help with the last cleanup you can check the |
Contributor
Author
|
Ok, changes are all done, and "Allow edits from maintainers" is checked. |
emilk
requested changes
Mar 25, 2021
egui_web/src/lib.rs
Outdated
| // ---------------------------------------------------------------------------- | ||
|
|
||
| pub fn handle_output(output: &egui::Output) { | ||
| pub fn handle_output(output: &egui::Output, _canvas_id: &str) { |
egui_web/src/lib.rs
Outdated
| request_animation_frame(runner_ref) | ||
| } | ||
|
|
||
| fn text_agent_hiddeh() -> bool { |
Contributor
Author
|
Ture, it is in master branch. I am not familiar with git, next time, all changes will be made in feature branch. |
They just add unnecessary complexity at this point
This reverts commit e8d9273.
* ci: install libspeechd-dev * Fix new clippy lints for rust 1.51.0
Contributor
Author
|
Oops, sad story, this PR is messed up, illly using of git rebase. Maybe I should close it, and commit a new PR again. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here. By adding a hidding input elemt, IME can be used on egui_web, both on desktop & mobile browsers. Tested on: