WIP feat: wire cluster autodiscovery into SlurmConfig and CLI#12
Open
gregorweiss wants to merge 6 commits into
Open
WIP feat: wire cluster autodiscovery into SlurmConfig and CLI#12gregorweiss wants to merge 6 commits into
gregorweiss wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects the autodiscovery module to existing infrastructure so users benefit from it without changing their workflow.
SlurmConfig.from_cluster()classmethod that auto-populates account/partition from discovered cluster infomdfactory config clusterCLI command to display discovered SLURM resourcesmdfactory config cluster --jsonfor machine-readable outputanalysis run --slurmandanalysis artifacts run --slurmto use autodiscovery when--accountnot providedFiles Changed
mdfactory/analysis/submit.pySlurmConfig.from_cluster()classmethodmdfactory/cli.pyconfig clustercommand, autodiscovery fallback in SLURM commandsmdfactory/tests/test_submit.pyfrom_cluster()mdfactory/tests/test_cli_cluster.pyconfig clustercommandTest plan
pytest mdfactory/tests/test_submit.py -v— all passpytest mdfactory/tests/test_cli_cluster.py -v— all passmdfactory config clusteron SLURM node shows cluster infomdfactory config clusteron laptop shows graceful message