Skip to content

Test @ember/string v4 without it being added to addon's package.json #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NullVoxPopuli wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Test @ember/string v4 without it being added to addon's package.json #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d295bdf
npm install
NullVoxPopuli Dec 3, 2024
297e093
Add @ember/string @ v4 to the sample-addon test
NullVoxPopuli Dec 3, 2024
3cd9422
ope
NullVoxPopuli Dec 3, 2024
e256e16
ope
NullVoxPopuli Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion test-scenarios/doubly-indirect-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ function makeAddon() {
'from-sample-addon.js': `
import Component from '@ember/component';
import { computed } from '@ember/object';
import { capitalize } from '@ember/string';
import layout from '../templates/components/from-sample-addon';
import { makeMessage } from 'some-lib';
export default Component.extend({
layout,
message: computed(function() {
return makeMessage();
return capitalize(makeMessage());
})
});
`,
Expand Down Expand Up @@ -128,6 +129,7 @@ appScenarios
// top-level auto-import is mandatory
project.linkDependency('ember-auto-import', { baseDir: __dirname });
project.linkDependency('webpack', { baseDir: __dirname });
project.linkDependency('@ember/string-', { baseDir: __dirname, resolveName: '@ember/string-v4' });

merge(project.files, {
app: {
Expand Down
1 change: 1 addition & 0 deletions test-scenarios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"@ef4/app-template": "*",
"@embroider/macros": "npm:@embroider/macros@latest",
"@embroider/addon-shim": "npm:@embroider/addon-shim@latest",
"@ember/string-v4": "npm:@ember/string@^4.0.0",
"@types/fs-extra": "^5.0.4",
"ember-auto-import": "file:../packages/ember-auto-import",
"fs-extra": "^6.0.1",
Expand Down