Resolve deprecations from ember barrel file #1537
Conversation
|
resolves #1536 |
|
|
||
| // @ts-ignore: this is private API. | ||
| const fallbackRegistry = Application.buildRegistry(namespace); | ||
| // TODO: only do this on Ember < 3.13 |
There was a problem hiding this comment.
Is this comment relevant? If so, do we even need to be supporting Ember < 3.13 here?
There was a problem hiding this comment.
We don't, but I'd argue cleanup for legacy stuff should be in a different PR (which I can submit next! as there are a number of other cleanup opportunities, I think)
| import EmberObject from '@ember/object'; | ||
|
|
||
| import Ember from 'ember'; | ||
| import { Registry } from '@ember/-internals/container'; |
There was a problem hiding this comment.
I know we specified these with the barrel deprecation RFC, but I wonder if there is anything in ember-source testing to make sure we don't break such import paths?
There was a problem hiding this comment.
they're all private API, so I think it's totally fair for ember to break them if it wishes.
@ember/test-helpers should not be using private APIs haha
(we can explore migrate off of them in a separate PR)
There was a problem hiding this comment.
They may be private but if we don't do that follow up PR all the pain will be ours.
There was a problem hiding this comment.
aye, I'm doing this now 🎉
| // | ||
| // import { registerWaiter } from '@ember/test'; | ||
| Ember.Test.registerWaiter(this._legacyWaiter); | ||
| registerWaiter(this._legacyWaiter); |
There was a problem hiding this comment.
TIL we support the legacy waiters still
There was a problem hiding this comment.
yea, and probably will continue to do so until they're deprecated
There was a problem hiding this comment.
I think the entire legacy test system is still in there...
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: Katie Gengler <[email protected]>
Co-authored-by: Katie Gengler <[email protected]>
No description provided.