Remove require usage, dropping support for automatic ember-data/setup-container inclusion #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Jul 30, 2024
| // Additionally, this file is deprecated with no replacement for | ||
| // removal in ember-data v6.0 | ||
| // See: ember-data/dist/setup-container | ||
| if (macroCondition(dependencySatisfies('ember-data', '< 6.0'))) { |
Collaborator
Author
There was a problem hiding this comment.
@runspired what happens with setup-container after v6? is it something that folks just need to configure manually?
Contributor
There was a problem hiding this comment.
hasn't been needed for some time / since late 1.x
Collaborator
Author
There was a problem hiding this comment.
Amazing thank you
Collaborator
Author
There was a problem hiding this comment.
Actually, i wonder if we should just drop this code, and do a major of test-helpers, bundled with the v2 addon conversion
NullVoxPopuli
force-pushed
the
dont-use-require
branch
from
193339a to
77a8821
Compare
NullVoxPopuli
changed the title
kategengler
approved these changes
Aug 19, 2024
runspired
approved these changes
Aug 19, 2024
Merged
Collaborator
Author
|
Resolved #1433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from: #1471