Stop transpiling non-existent vendor tree #1049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Appreciate the fix, but why did this not fail |
richgt
approved these changes
Jun 15, 2021
Contributor
richgt
left a comment
richgt
left a comment
There was a problem hiding this comment.
Approving since it seems to be blocking many people. Would love to see a test as a followup.
Member
|
ZOMG, so sorry for this!!! I totally didn't look for an open PR when I opened #1050 🤦 I'm releasing that fix now |
Member
Ya, totally agree. I'm going to try to diagnose why this didn't fail our own CI. |
Member
|
Fix released as 2.2.8, sorry about this folks :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048